Skip to content

fix(review): recalibrate interactive findings - #463

Merged
christso merged 1 commit into
mainfrom
fix/pr-interactive-review-feedback-loop
Sep 7, 2026
Merged

fix(review): recalibrate interactive findings#463
christso merged 1 commit into
mainfrom
fix/pr-interactive-review-feedback-loop

Conversation

@christso

@christso christso commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Problem

Interactive PR review comments could disprove a finding while the original card, severity, scenario, counts, and verdict remained stale. Scenario sidecars could assert an active failure without separate reachability and outcome provenance.

Behavior

  • Migrates local review.json workspaces from v1 to v2 deterministically; comments.json remains v1.
  • Adds active, question, and withdrawn finding states, immutable original claims, and append-only comment-linked revisions through POST /api/findings/%23<id>/revisions.
  • Recalculates the visible verdict from active findings only; status groups, filters, search, audit history, and counts reflect the current lifecycle state.
  • Requires scenario assertions to carry distinct trigger/reachability and observable-outcome evidence; unsupported assertions render as evidence gaps.
  • Preserves lifecycle state on same-commit re-prepare and refuses operations that would discard revision history.
  • Wraps long prose in titles, metadata, scenarios, evidence, comments, and replies while preserving horizontal code scrolling.

Security

The new route reuses JSON content-type validation, same-origin write enforcement, request size limits, bounded atomic persistence, per-review locking, comment-to-finding linkage, loopback-by-default hosting, and no GitHub posting. The non-loopback warning now explicitly includes lifecycle revisions.

Verification

  • bun test tests/unit/plugins/pr-interactive-review.test.ts — 13 passing tests.
  • bun run typecheck — passed.
  • bun run lint — passed (92 source files).
  • bun run build — passed.
  • Browser E2E: prepared and served an external temporary workspace, submitted a reviewer correction, posted the assistant reply and comment-linked withdrawal, then confirmed desktop and 390px renders show No active findings, Withdrawn findings (1), preserved comment/reply and lifecycle history; narrow viewport had no document horizontal overflow (scrollWidth 375 at innerWidth 390).

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying allagents with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae94667
Status: ✅  Deploy successful!
Preview URL: https://dd9ab3f3.allagents.pages.dev
Branch Preview URL: https://fix-pr-interactive-review-fe.allagents.pages.dev

View logs

@christso
christso merged commit 0f57b75 into main Sep 7, 2026
9 of 11 checks passed
@christso
christso deleted the fix/pr-interactive-review-feedback-loop branch September 7, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant